Repository navigation
Codex/studio cloud ai browser - #166
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f39d56d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (studio.account?.id !== account?.id) { | ||
| studio.preview.stop(); | ||
| studio.document = null; studio.workspace = null; studio.projects = []; | ||
| } | ||
| if (account && !studio.account) await studio.start(); |
There was a problem hiding this comment.
When the embedded Cloud panel reports a different non-null account without first reporting a sign-out, this branch clears the workspace state but skips studio.start() because studio.account still refers to the previous user. The new account is then assigned while projects remains empty and provider/AI-credit state remains associated with the previous session; refresh all account-scoped state whenever the account ID changes, not only when the old account is null.
AGENTS.md reference: Editor/AGENTS.md:L600-L601
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce4a82a096
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func resolvePermission(requestID: String, optionID: String?) async { | ||
| permissions.removeValue(forKey: requestID)?.1.resume(returning: optionID == "allow") |
There was a problem hiding this comment.
After a user allows or rejects a mutating Cloud tool, this method only resumes the continuation and never emits a replacement permission event with .selected or .cancelled. The original .pending event therefore remains in the running and persisted Cloud conversation, leaving desktop transcripts with an actionable approval card and mobile history claiming approval is still required even though the tool already proceeded or was denied. Emit the resolved event as the ACP permission path does.
AGENTS.md reference: Editor/AGENTS.md:L605-L605
Useful? React with 👍 / 👎.
| Text(permission.summary).font(MobileEditorFont.font(size: 13)).foregroundColor(theme.editorColors.muted).lineLimit(4) | ||
| HStack(spacing: 12) { | ||
| MobileEditorPrimaryButton(title: "Allow once") { resolveCloudPermission("allow") } | ||
| MobileEditorPrimaryButton(title: "Reject") { resolveCloudPermission("deny") } |
There was a problem hiding this comment.
In a Russian session, the Cloud mutation prompt renders this button through MobileEditorPrimaryButton, which calls L10n.tr(title), but "Reject" is absent from both localization catalogs. Consequently this newly added approval UI falls back to the English label while the rest of the prompt is Russian; add the key to en.json and ru.json.
AGENTS.md reference: Editor/AGENTS.md:L60-L65
Useful? React with 👍 / 👎.
1 participant
No description provided.