Skip to content

move phase_groups into abstract parents class - #59

Merged
sadda merged 4 commits into
mainfrom
57-fix-hard-coded-number-of-phases
Oct 1, 2026
Merged

sadda merged 4 commits into
mainfrom
57-fix-hard-coded-number-of-phases

Conversation

@haitao-ZCU

Copy link
Copy Markdown
Collaborator
  • move n_phase and belt_offset to geometry part
  • move phase_groups() to ComputationBase like compute_initpos()

the remaining parameterizing n_phase will be proposed in a seperate PR.

@haitao-ZCU haitao-ZCU linked an issue Oct 1, 2026 that may be closed by this pull request
@haitao-ZCU haitao-ZCU changed the title mvoe phase_groups into abstract parents class move phase_groups into abstract parents class Oct 1, 2026
@sadda
sadda merged commit c33b87b into main Oct 1, 2026
6 checks passed
@haitao-ZCU
haitao-ZCU deleted the 57-fix-hard-coded-number-of-phases branch October 1, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix hard-coded number of phases

2 participants