fix: decode_all should stop iterating after encountering an error - #44
Merged
Merged
Conversation
jxors
force-pushed
the
fix-decode-all-infinite-iter
branch
3 times, most recently
from
November 20, 2025 17:15
f6b879f to
1e079ad
Compare
jxors
force-pushed
the
fix-decode-all-infinite-iter
branch
from
November 20, 2025 17:16
1e079ad to
bbbf3a5
Compare
athre0z
approved these changes
Nov 28, 2025
athre0z
left a comment
athre0z
left a comment
Member
There was a problem hiding this comment.
Thank you for taking this up, this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures
InstructionIterterminates after yielding an error, and adds a test for this behavior. This fixes #42.