Repository navigation
Fix atomic benchmark result publication - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security invariant
A successful canonical bundle appears with
report.md,manifest.json, andCOMPLETEtogether. Publication never replaces an existing destination. Handled failures leave the canonical name free and removeCOMPLETEfrom retained staging evidence.Validation
coverage run -m unittest discover -s tests -v— 54 passedcoverage report --fail-under=80— 87%python3 scripts/verify_no_copied_skills.py— passedpython3 scripts/run_benchmark.py --help— passedGitHub Actions is expected to provide the native Linux
renameat2(RENAME_NOREPLACE)execution check.Boundaries
This does not claim crash durability, protection against an arbitrary malicious same-user process replacing staging or ancestor paths, or independent publication witnessing. A marker-removal failure caused by a filesystem-wide write failure is reported explicitly.
Follow-up to #2, which was merged with the publication race still documented as unresolved.