Repository navigation
Search throttler - #126
Open
savage13 wants to merge 3 commits into
Open
Search throttler#126savage13 wants to merge 3 commits into
savage13 wants to merge 3 commits into
Conversation
Member
|
can we just compare the search query instead of comparing IDs? |
Contributor
Author
|
Sounds good to me, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching for objects, the debounce() function can call multiple instances of search() and these collide if the network activity persists for too long.
searchID, increment on eachsearchOnInput()this.searchIDmatches functions localsearchIDsearchOnInput()which sets the ID properly before calling the debouncedsearch()Example: Sometimes searching for
appleresulted an incorrect list of results with the first search onareturning after the final search forappleThis is a minor, but very confusing, annoyance on one of the main functions of the site. If this results in more issues we can discard this.
This change is