You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current state should enable encoding and decoding of Ambix / Higher-order ambisonics with the standard opus tools.
Any reviews or suggestions are very welcome.
@chris-hld I am not a maintainer of opusfile, but I imagine the maintainers might like a cleaner commit history on this PR in order to consider it. I am happy to help test this
I took care of a last warning and completed the cleanup and documentation / commenting.
Everything related to mapping 3 should now also be guarded by OPUS_HAVE_OPUS_PROJECTION_H.
I am using and testing the modes of this PR daily and at least for me it's all working as expected.
Regarding the commit history, I completely agree. Feel free to squash on merge! If needed I can also rework the history and make it more compact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ambisonics is currently not available in opusfile.
This PR is aiming to start implementing the remaining mappings for Opus and its tools.