Skip to content
This repository was archived by the owner on Sep 17, 2026. It is now read-only.

formula: dlbeer/quirc - #512

Open
MeteorsLiu wants to merge 1 commit into
xgo-dev:mainfrom
MeteorsLiu:issue/250-quirc-luna
Open

MeteorsLiu wants to merge 1 commit into
xgo-dev:mainfrom
MeteorsLiu:issue/250-quirc-luna

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

Summary

  • Add the dlbeer/quirc LLAR Formula with exact v1.0, v1.1, and v1.2 thresholds.
  • Preserve the Conan Center portability patches for v1.0 and v1.1, shared/fPIC defaults, and the max_regions option.
  • Install the public header, library, ISC license, and relocatable quirc.pc metadata.

Validation

  • LLAR 9c062aa5c4b1724bfd30cb72f7e0bda136f9c078 local llar test --verbose passed for v1.0, v1.1, and v1.2 on explicit darwin/arm64.
  • Passed v1.0 with max_regions=65534, v1.2 with max_regions=65534, v1.2 with shared=ON, and v1.2 with fPIC=OFF.
  • Invalid max_regions=1 was rejected by the Formula filter.
  • Repeated v1.2 default testing passed on a cache hit and reran the consumer.
  • v0.9 was rejected because no Formula exists below v1.0.

Closes #250

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version thresholds, Conan portability patches, installed interface, and pkg-config consumer path are internally consistent. Using LLAR 9c062aa5c4b1724bfd30cb72f7e0bda136f9c078, I validated v1.0, v1.1, and v1.2 on linux/amd64, plus the v1.2 shared and max_regions=65534 option path. The remaining blocker is the repository's changed-module discovery contract, which rejects this multi-threshold diff before the platform test matrix runs.


id "dlbeer/quirc"

fromVer "v1.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Keep the module to one changed Formula directory

The repository's .github/scripts/find_changed_modules.gsh unconditionally aborts when a module changes more than one directory containing an *_llar.gox file. Adding this v1.1 threshold alongside the new v1.0 and v1.2 thresholds makes the fixed diff resolve to three Formula directories, so the Find changed modules job panics before any llar test matrix can be generated and this PR cannot pass the required workflow. Please first add CI support for validating multiple thresholds, or publish the thresholds in diffs that each change only one Formula directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Conan Center quirc recipe to LLAR

1 participant