formula: dlbeer/quirc - #512
MeteorsLiu wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
The version thresholds, Conan portability patches, installed interface, and pkg-config consumer path are internally consistent. Using LLAR 9c062aa5c4b1724bfd30cb72f7e0bda136f9c078, I validated v1.0, v1.1, and v1.2 on linux/amd64, plus the v1.2 shared and max_regions=65534 option path. The remaining blocker is the repository's changed-module discovery contract, which rejects this multi-threshold diff before the platform test matrix runs.
|
|
||
| id "dlbeer/quirc" | ||
|
|
||
| fromVer "v1.1" |
There was a problem hiding this comment.
[P1] Keep the module to one changed Formula directory
The repository's .github/scripts/find_changed_modules.gsh unconditionally aborts when a module changes more than one directory containing an *_llar.gox file. Adding this v1.1 threshold alongside the new v1.0 and v1.2 thresholds makes the fixed diff resolve to three Formula directories, so the Find changed modules job panics before any llar test matrix can be generated and this PR cannot pass the required workflow. Please first add CI support for validating multiple thresholds, or publish the thresholds in diffs that each change only one Formula directory.
Summary
dlbeer/quircLLAR Formula with exactv1.0,v1.1, andv1.2thresholds.v1.0andv1.1, shared/fPIC defaults, and themax_regionsoption.quirc.pcmetadata.Validation
9c062aa5c4b1724bfd30cb72f7e0bda136f9c078localllar test --verbosepassed forv1.0,v1.1, andv1.2on explicitdarwin/arm64.v1.0withmax_regions=65534,v1.2withmax_regions=65534,v1.2withshared=ON, andv1.2withfPIC=OFF.max_regions=1was rejected by the Formula filter.v1.2default testing passed on a cache hit and reran the consumer.v0.9was rejected because no Formula exists belowv1.0.Closes #250