Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
timeparse()mis-parses the output ofdatetime.timedelta.__str__for negative durations, causing a round-trip drift (issue #23).timedelta.__str__renders negative durations as-N day[s], HH:MM:SS[.ffffff], where the leading-negates only the day count and the clock part is always non-negative:timeparseinstead extracted the leading sign and negated the entire field sum, so-1 day, 0:00:05became-(86400 + 5) = -86405. Repeating the round-trip drifts every iteration:Fix
_sum_fields(mdict, sign)helper (behaviour-preserving refactor).HH:MM:SSclock), a leading minus now negates only the week/day portion while the clock stays positive, matchingtimedeltasemantics. TheDAYCLOCK(DD-HH:MM:SS) and unit forms keep their existing whole-expression sign behaviour.Now
-1 day, 0:00:05→-86395and the round-trip is stable.Tests
test_timeparse_11/test_timeparse_12, whose old expected values encoded the previous (incorrect) whole-expression negation.test_negative_day_clockandtest_negative_timedelta_roundtripcoveringstr(timedelta(...))round-trips.Verification:
python -m unittest discover -s pytimeparse/tests→ 62 tests, OK.