Repository navigation
Conversation
One order: authorize, capture over a wire that loses replies, settle, ship, refund, cancel. Without a key, a lost reply and a retry charge twice in six steps; derive double-charged shows the order looking normal in every stage. The shortcut also charges for a cancelled order: the void overtakes the capture, finds nothing, and the capture lands after it. Writing it, writ failed the first draft of the SAFE file, key and all: cancel was allowed whenever the shop had not captured, so a capture still on the wire landed after the cancellation. cancel now voids at the processor, under the same key. Cross-check 52 -> 56 properties (54 compared); 314 checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Superseded: reached main through #10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7 (base
deployment).Adds
payments/: one order going through authorize, capture, settle, ship, refund and cancel, over a wire that loses replies, with a shop that retries. The pair is with and without an idempotency key.authorize → send-capture → capture → lose-reply → send-capture → capture-again, and the customer is charged twice.derive double-chargedshows those orders looking normal in every stage, including settled-and-shipped, refunded and cancelled.cancelwas allowed whenever the shop had not captured, so a capture still in flight landed after the cancellation.cancelnow voids at the processor under the same key. The README tells the story.Cross-check: 52 → 56 properties (54 compared).
./run-tests.sh all: 314 checks, 0 failed.🤖 Generated with Claude Code