Skip to content

Don't provide blocks for RobotPy APIs that depend on un-exported classes - #630

Merged
alan412 merged 6 commits into
wpilibsuite:mainfrom
lizlooney:pr_ignore
Nov 12, 2026
Merged

alan412 merged 6 commits into
wpilibsuite:mainfrom
lizlooney:pr_ignore

Conversation

@lizlooney

Copy link
Copy Markdown
Collaborator

Overview

Ignore TelemetryLoggable and ComplexTunable and methods inherited from TelemetryLoggable and ComplexTunable in subclasses.

Ignore robotpy APIs that depend on un-exported classes

Linked Issues

Fixes #560

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to change)
  • Documentation update
  • Code style/formatting updates
  • Refactoring / Renaming
  • UI change
  • Blocks style change
  • Blocks theme change
  • Python tools
  • Other

How Has This Been Tested?

I reviewed the diff of the regenerated JSON.
I checked that the toolbox category for AnalogInput does not have blocks for log_to or get_telemetry_type methods.

Screenshots (if applicable)

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run through the docs/testing_before_pr_checklist.md

…class variables, instance variables, constructors, instance methods, static methods, and class enums, if they relate to types that are not exported.
…les, instance variables, constructors, instance methods, static methods, and class enums, if they relate to types that are not exported.
…m TelemetryLoggable and ComplexTunable in subclasses.
@lizlooney
lizlooney requested a review from alan412 November 12, 2026 08:16

@alan412 alan412 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified that I get the same generated JSON when I run on my side. I didn't see anything obvious in things we have that we shouldn't or things that got dropped that we need.

@alan412
alan412 merged commit 689d818 into wpilibsuite:main Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

robotpy_data.json contains unusual (unexported?) class names

2 participants