Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Use the existing installation-directory copy for SQLite databases. It already includes the database files and db-path.php, including the randomized directories introduced for SQLite Database Integration 3.1. Remove the separate fixed-filename snapshot and its validity and cleanup logic. Cache reuse now depends on the installation directory existing, so an incomplete copy within a suite no longer triggers a rebuild based on the missing snapshot. Each suite still starts with an empty cache. Add a focused regression test for path preservation and independent databases across a cold installation and two warm restores. WordPress/sqlite-database-integration#502 WordPress/sqlite-database-integration#512
c69a16d to
a9af46b
Compare
SQLite Database Integration 3.1 will introduce randomized database directories, with
db-path.phprecording the location relative to its own directory. The.sqlitecache snapshot currently looks for.ht.sqliteand.ht.sqlite.phpinwp-content/database. With randomized storage paths, that snapshot is never created, so the installation cache is considered invalid, and each scenario repeatswp core install.Upon a closer look, it turns out the separate SQLite cache snapshot is not needed, because the SQLite database is already part of the WordPress install snapshot. Removing the duplicate
.sqlitesnapshot with the fixed-filename lookup simplifies the logic and makes SQLite database caching work also with the new randomized storage.A focused regression scenario checks path preservation and independent databases across a cold installation and two warm restores. It was tested against the merged SQLite plugin code and releases 3.0.2 and 2.2.23.
Related: WordPress/sqlite-database-integration#502 and WordPress/sqlite-database-integration#512.