Repository navigation
Fix PHPStan errors - #100
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Q2gK8eSLNEQDwqibeyVJ6
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughWhen discovery is disabled and either discovery-only option is supplied, the error message now names the supplied option or options. The validation condition and error outcome are unchanged. ChangesDiscovery option wording
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change adjusts the discovery-disabled error message. The supplied review context reports feature coverage for each option combination, and no material merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fixes the newly reported PHPStan errors from the scheduled code quality run (https://github.com/wp-cli/embed-command/actions/runs/37563667796):
wp embed provider matchvalidated--limit-response-size/--link-typewithout discovery by checking each value fornullseveral times in nested conditions, and PHPStan flagged the repeated checks. This PR checks each option once, collects the ones that were passed and builds the error message from that list. The error messages are exactly the same as before; they're covered byfeatures/provider.feature.🤖 Generated with Claude Code
https://claude.ai/code/session_014Q2gK8eSLNEQDwqibeyVJ6
Generated by Claude Code
Summary by CodeRabbit