Rust wrapper: ecc: fix check() return value comment - #11385
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Rust wrapper: ecc: fix check() return value comment#11385holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
Fixes F-12247.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a documentation-only correction that aligns with the verified check() signature and implementation.
Pull request overview
This PR corrects the Rust wrapper documentation for ECC::check() in wolfssl-wolfcrypt to match the actual return type and behavior (sanity-checking an ECC key and returning Ok(()) on success or a wolfSSL error code on failure).
Changes:
- Fixes the
ECC::check()Rustdoc “Returns” section to documentResult<(), i32>correctly.
File summaries
| File | Description |
|---|---|
| wrapper/rust/wolfssl-wolfcrypt/src/ecc.rs | Updates ECC::check() return-value documentation to match the function signature and behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
retest this please (Unable to get pull request builder trigger!!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: ecc: fix check() return value comment
Fixes F-12247.
Testing
How did you test?
Checklist