Rust wrapper: rsa: update pss_check_padding() docs to not require set_rng() - #11384
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Rust wrapper: rsa: update pss_check_padding() docs to not require set_rng()#11384holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
…_rng() Fixes F-10084.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a documentation-only correction that matches the actual API behavior (no RNG/key dependency in wc_RsaPSS_CheckPadding).
Pull request overview
This PR updates the Rust wolfCrypt RSA wrapper documentation to clarify that RSA::pss_check_padding() does not require calling set_rng() beforehand (even when wolfSSL is built with WC_RSA_BLINDING enabled), aligning the docs with the underlying C API usage.
Changes:
- Removed the doc note claiming
set_rng()must be called beforepss_check_padding()whenWC_RSA_BLINDINGis enabled.
File summaries
| File | Description |
|---|---|
| wrapper/rust/wolfssl-wolfcrypt/src/rsa.rs | Removes an incorrect set_rng() prerequisite from pss_check_padding() rustdoc. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: rsa: update pss_check_padding() docs to not require set_rng()
Fixes F-10084.
Testing
How did you test?
Checklist