add ssh server extended key usage parsing and missing ssh extended ke… - #11361
add ssh server extended key usage parsing and missing ssh extended ke…#11361JacobBarthelmeh wants to merge 2 commits into
Conversation
…y parsing to asn template from asn orig
There was a problem hiding this comment.
🟢 Approval recommended
The added SSH server EKU support is consistently wired through OID tables, decoding logic, and is covered by a focused regression test.
Pull request overview
Adds support for decoding the RFC 6187 SSH server Extended Key Usage (EKU) OID into wolfSSL’s SSH-specific EKU bitfield, bringing parity across ASN parsing implementations and validating behavior with an API test.
Changes:
- Add
id-kp-secureShellServer(1.3.6.1.5.5.7.3.22) to the EKU OID tables and OID->bytes mapping. - Extend EKU decoding to set a new
EXTKEYUSE_SSH_SERVER_AUTHbit when the SSH server EKU is present. - Add an API test that parses a self-signed certificate containing only the SSH client/server EKUs and asserts the decoded SSH EKU flags.
File summaries
| File | Description |
|---|---|
| wolfssl/wolfcrypt/oid_sum.h | Adds the SSH server-auth EKU identifier to the summarized OID enum values. |
| wolfssl/wolfcrypt/asn.h | Introduces the EXTKEYUSE_SSH_SERVER_AUTH bit for decoded SSH EKUs. |
| wolfcrypt/src/asn.c | Adds SSH server-auth OID bytes + OidFromId mapping and decodes SSH EKUs into extExtKeyUsageSsh. |
| wolfcrypt/src/asn_orig.c | Mirrors the SSH server-auth decoding change for the non-template ASN path. |
| tests/api/test_asn.h | Registers the new ASN API test in the test declarations/group list. |
| tests/api/test_asn.c | Adds a targeted regression test for decoding SSH client/server EKUs into the SSH EKU bitfield. |
| scripts/asn1_oid_sum.pl | Updates the OID-sum generation script to include the SSH server-auth EKU. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11361
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent across OID tables, decoder logic, and tests, and the added coverage specifically targets the new EKU and the collision-hardening behavior.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Lite
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11361
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
No description provided.