Fenrir Fix: Added cheap bounds checking to FREESCALE des - #11360
Open
aidankeefe2022 wants to merge 1 commit into
Open
Fenrir Fix: Added cheap bounds checking to FREESCALE des#11360aidankeefe2022 wants to merge 1 commit into
aidankeefe2022 wants to merge 1 commit into
Conversation
Check that the bottm 3 bits of any input size are 0.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11360
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Member
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that the bottom 3 bits of any input size are 0.
Description
Bounds are already checked at internal call sights but this is a public api and an easy OOB error to hit.
Fenrir Fix: https://fenrir.wolfssl.com/finding/12171
IMO test not needed due to simplicity of change.