Add TLS 1.3 Cover Traffic Support (RFC 8446 Appendix E) - #11357
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11357
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
| #endif | ||
| ssl->options.hrrSentKeyShare = 0; | ||
| /* Don't let a request abandoned mid-pending survive object reuse. */ | ||
| Tls13ClearCoverTraffic(ssl); |
There was a problem hiding this comment.
Tls13ClearCoverTraffic() called from wolfSSL_clear() under the wrong preprocessor guard · API contract violations
Tls13ClearCoverTraffic() is defined in src/tls13.c, whose body is #if !defined(NO_TLS) && defined(WOLFSSL_TLS13), but the new call site is guarded only by #ifdef WOLFSSL_TLS13. configure.ac:1354 keeps WOLFSSL_TLS13 defined for --disable-tls, so a --disable-tls (non-cryptonly) build compiles ssl.c with an undefined reference. Other TLS-only work in the same function (e.g. TLSX_FreeAll at ssl.c:5736) is guarded with !defined(NO_TLS).
Fix: Change the guard to #if defined(WOLFSSL_TLS13) && !defined(NO_TLS).
|
Description
Implemented TLS 1.3 cover traffic, allowing the application to send empty, padded records to obscure actual traffic patterns.
Issue #11086
Testing
Added test coverage
Checklist