Remove samplingMode default from IDL; update comments - #215
Merged
Merged
Conversation
github-actions Bot
added a commit
that referenced
this pull request
Aug 11, 2026
SHA: 7a0a7d7 Reason: push, by isaacahouma Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
isaacahouma
pushed a commit
to isaacahouma/prompt-api
that referenced
this pull request
Sep 22, 2026
Follow-up to webmachinelearning#206, webmachinelearning#210, and webmachinelearning#215. Those PRs updated the explainer and added the LanguageModelSamplingMode WebIDL declarations, but left out the algorithm steps in index.bs. - Make LanguageModel.samplingMode nullable (LanguageModelSamplingMode?) in the IDL to match LanguageModelCreateCoreOptions.samplingMode and Chromium's behavior when samplingMode is omitted. - Throw TypeError in validate and canonicalize language model options when both samplingMode and topK/temperature are provided. - Wire sampling mode into LanguageModel's internal slots, getter, creation, prefill, generate, and clone steps alongside top K and temperature. Bug: 561753033
michaelwasserman
pushed a commit
that referenced
this pull request
Sep 24, 2026
* Specify samplingMode algorithms and slot in index.bs Follow-up to #206, #210, and #215. Those PRs updated the explainer and added the LanguageModelSamplingMode WebIDL declarations, but left out the algorithm steps in index.bs. - Make LanguageModel.samplingMode nullable (LanguageModelSamplingMode?) in the IDL to match LanguageModelCreateCoreOptions.samplingMode and Chromium's behavior when samplingMode is omitted. - Throw TypeError in validate and canonicalize language model options when both samplingMode and topK/temperature are provided. - Wire sampling mode into LanguageModel's internal slots, getter, creation, prefill, generate, and clone steps alongside top K and temperature. Bug: 561753033 * Default samplingMode to balanced unless legacy params are used * Document null samplingMode when legacy params are used in README.md --------- Co-authored-by: Isaac Ahouma <iahouma@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview | Diff