Repository navigation
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES
Adds the requested consumer bundler release checks as a follow-up to #751. No separate issue was supplied.
This pull request addresses
A package can pass the repo's Webpack build and still fail when a host app uses another bundler. The wellness media regression is one example. We need to check consumer builds before publishing a release, and make each bundler check configurable.
Dependency: merge #751 first. This branch starts from
nextatc298215cand includes only the workflow, fixtures, tests, and documentation. It does not include the media fix. Currentnextfails the new Vite check as expected.by making the following changes
nextand for release checks.tooling/consumer-builds/config.jsonfile for both paths. Webpack, Vite, Parcel, Rollup, and esbuild are enabled by default. Set a bundler'senabledflag tofalseto omit its check. Invalid flags and disabling all five fail validation.@webex/test-fixturesfrom npm publishing.ai-docs/CONSUMER_BUILDS.mddocument and its spec index links.Change Type
The following scenarios were tested
nextcandidate: Vite rejected the exact!!./emit-wellness-asset.cjs!./WellnessBreakSound.mp3request. Webpack passed. This proves that a passing repository Webpack build does not cover the regression.645707ff: all five consumers passed their builds and browser startup checks. Each result matched the SHA-256 hashes for the same nine archives. No source changes from fix(cc-widgets): restore bundler compatibility for wellness media #751 were added to this branch.falseremoved it from the matrix, and a direct Parcel invocation failed before installation. Restored all five default flags.actionlint, Prettier checks, immutable install after edits, staged secret-pattern scan, andgit diff --check.nextdist tag. An already-published legacy version was rejected as expected. No package was published.Browser: Playwright 1.64.0 and Chromium 156.0.8078.4. These checks cover the fixture and pinned versions. They do not cover all consumer configurations, development servers, media playback, CSP policies, or authenticated agent sessions. GitHub Actions execution has not yet been verified. The existing fork PR CI also needs a code owner to add the
validatedlabel.Testing and configuration:
ai-docs/CONSUMER_BUILDS.md.Rollback: revert this workflow change. To omit one bundler check, change its config flag.
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
nextconsumer candidate must remain failing until fix(cc-widgets): restore bundler compatibility for wellness media #751 merges. GitHub checks are pending.Make sure to have followed the contributing guidelines before submitting.