Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1006.
Accept
options.signal, preserve it in generated request details, and forward it to the native HTTPS request and the per-request proxy agent. Forwarding it to the proxy agent also cancels a pending CONNECT handshake.Cancellation uses Node.js's native
AbortError; socket timeouts and HTTP errors retain their behavior. Custom agents remain responsible for their own connection setup. No new dependencies.Validation on Node 22.23.4 and 26.13.0: 142 tests passed on each, including 11 new tests for cancellation, signal propagation, cleanup, success, HTTP errors, timeouts, and a stalled proxy. With the original implementation, 10 of the 11 new tests fail; the no-signal compatibility test already passes. Lint passes.
Commands:
Browser tests that deliver notifications through external push providers were not run.