Repository navigation
Guard original integer variables during ALASCA conversion - #1031
Open
shalashaska117 wants to merge 1 commit into
Open
shalashaska117 wants to merge 1 commit into
shalashaska117 wants to merge 1 commit into
Conversation
Collect variable sorts before normalizing the clause and add one integrality guard for each integer variable. Guarding a normalized expression such as 2*x does not restrict x to integer values. Cover scaled equality, predicate arguments, repeated variables, mixed sorts and ground arithmetic with native regressions. Closes vprover#940.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integer-to-real conversion guards normalized literal arguments. For
2*k != a, requiring2*k-ato be integral admits non-integral values ofk, which leads to the false all-even theorem in #940.Collect variable sorts before normalization and add one integrality guard per original integer variable. This also covers variables inside uninterpreted predicates and leaves real variables unrestricted. Existing function-integrality axioms are unchanged.
Closes #940.
Checks
checks/sanitypass.GaveUp. Several controls remain inconclusive, including the true parity conjecture; this change does not make integer conversion complete.