Repository navigation
Preserve first-order constraints in the HOL unifier wrapper - #1030
Closed
shalashaska117 wants to merge 1 commit into
Closed
shalashaska117 wants to merge 1 commit into
shalashaska117 wants to merge 1 commit into
Conversation
Only run higher-order constraint search for hol and func_ext abstraction. Other modes retain their first-order substitution and constraints, so equality resolution cannot discard the arithmetic condition in vprover#938. Add a regression for the satisfiable clause -(-x + -1) != x. Closes vprover#938.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equality resolution passes first-order abstraction constraints through
HOL::AbstractingWrapper. Its higher-order search assumes applicative terms and can lose the arithmetic constraint in #938, producing a false refutation in Release and an assertion failure in Debug.Run that search only for
holandfunc_extabstraction modes. Other modes return a copy of the first-order unifier with its constraints intact. The regression checks that equality resolution retains the constraint for-(-x + -1) != x.Closes #938.
Checks
checks/sanitypass.