Repository navigation
1023 literal code tree does not handle two variable equality sort matching - #1029
Merged
mezpusz merged 4 commits intoOct 19, 2026
Conversation
… the same order as Renaming::normalizeVariables normalizes terms
…izations The substitution a code tree returns is expressed in terms of the key's variables as numbered by Renaming::normalizeVariables, so the code tree has to number the variables of an equality literal in the same order (arguments, then sort). This was not the case before the previous commit. Reproducer: TermIndex/gen_equality_sort_variable_order (hits the TermSharing.cpp:139 assertion on the parent of the previous commit). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…hingUtils Inserts a pool of equalities (two-variable ones with various sorts, reversed, polymorphic, negative) and predicates into one CodeTreeLIS and checks, for 39 queries in both polarities, that the keys found are exactly those accepted by MatchingUtils::match, and that each returned substitution maps its key to the query or to the query's reversal. Reproducer: TermIndex/gen_equality_agrees_with_matching_utils (hits the Term.cpp:1564 assertion on the parent of the fix for #1023). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the bug (flipped from failing to successful)
quickbeam123
approved these changes
Oct 19, 2026
mezpusz
deleted the
1023-literal-code-tree-does-not-handle-two-variable-equality-sort-matching
branch
October 19, 2026 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes matching order for equations inside code trees from
=to
=in order to have the same order as in
Renaming::normalizeVariables(Literal*). Regression shows a small improvement:Discount FOL TPTP
run 0 unsat: 9292 (5) sat: 1044 (0) cputime: 60377.99 s instructions: 221610494 Mi memory: 1787712.59 MB
run 1 unsat: 9292 (5) sat: 1045 (1) cputime: 60287.47 s instructions: 221558710 Mi memory: 1796447.31 MB
Otter FOL TPTP
run 0 unsat: 9399 (6) sat: 1027 (0) cputime: 65607.93 s instructions: 221405555 Mi memory: 2023197.09 MB
run 1 unsat: 9410 (17) sat: 1027 (0) cputime: 65471.70 s instructions: 221274798 Mi memory: 2037041.06 MB
10 rounds of debug sampling shows no sign of the bug #1023 anymore, previously there were a few instances each round.