Repository navigation
Labeled demodulation - #1022
Merged
Merged
Labeled demodulation#1022
Conversation
…in DemodulationHelper
Contributor
Author
|
If this gets merged, let's squash the commits by GitHub's "squash and merge". |
quickbeam123
approved these changes
Oct 20, 2026
quickbeam123
approved these changes
Oct 20, 2026
MichaelRawson
approved these changes
Oct 20, 2026
MichaelRawson
left a comment
Contributor
There was a problem hiding this comment.
Cool! I'm OK with the option, but this one seems like it "always makes sense" especially if we're paying for encompassment demodulation anyway - how would you feel about this being part of the regular encompassment implementation?
Contributor
Author
|
I wouldn't be against it, but the results suggest it's not a clear improvement, so I don't mind it being a non-default option if you don't mind having one more option. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small improvement I had lying around.
Adds one more demodulation redundancy check option that squeezes a bit more out of encompassment demodulation. Namely, we can also demodulate one ordered equation with another if their LHSs are renamings of each other but they are incomparable (when normalized to the same variables). In this case we just break tie by looking at the clause number. This of course does not help too much, as there are usually not so many such equation pairs, so I hid it behind a new option for strategizing.
Also tightened the demodulation redundancy check code a bit.
Results:
DIscount FOL TPTP
run 0 unsat: 9292 (18) sat: 1044 (1) cputime: 60321.32 s instructions: 221610392 Mi memory: 1787763.52 MB
run 1 unsat: 9302 (28) sat: 1044 (1) cputime: 60225.97 s instructions: 221463251 Mi memory: 1782538.74 MB
Otter FOL TPTP
run 0 unsat: 9399 (26) sat: 1027 (0) cputime: 65487.18 s instructions: 221404490 Mi memory: 2023222.52 MB
run 1 unsat: 9395 (22) sat: 1027 (0) cputime: 65517.28 s instructions: 221489242 Mi memory: 2028634.55 MB
No change for HOL TPTP