馃悰 Keep Swift preview names stable across schemes - #370
Merged
Merged
Conversation
Use Xcode preview names without the selected scheme so builds from different schemes compare against the same screenshot identities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Swift preview capture currently prefixes each screenshot name with its Xcode scheme. That makes the same preview produce different Vizzly screenshot identities when captured from another scheme, so the schemes cannot share comparisons.
Approach
Use the Xcode preview name as the screenshot name, independent of scheme. Keep the scheme in screenshot metadata and retain suffixes only when needed to distinguish duplicate preview names.
Evidence
The focused naming tests and package lint pass. The full local package test run reaches a Node 26 assertion during test-process cleanup after the test assertions pass, so CI should confirm the complete suite.