Repository navigation
ci: run the spec-clauses mise tasks under bash - #963
Merged
Merged
Conversation
gen-, check- and test-spec-clauses open with `set -euo pipefail`, but mise runs an inline `run` script through sh, which is dash on ubuntu-latest and has no pipefail option, so Format & Metadata failed before the check did any work. Give each task `shell = "bash -c"`. Closes #962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format & Metadatafails atcheck-spec-clauseswithsh: 1: set: Illegal option -o pipefail. mise runs an inlinerunscript throughsh, which is dash onubuntu-latest. This failure blocks every open PR, including #955, #961 and the release PR #820.Change
gen-spec-clauses,check-spec-clausesandtest-spec-clausesinmise.tomleach getshell = "bash -c".pipefailstays, because #962 notes it is load-bearing.Verification
shellkey: a scratch task withshell = "zsh -c"reports/usr/bin/zshas its interpreter.mise run check-spec-clausespasses locally. The dash case itself is proven only by this PR's CI, since/bin/shis bash on the dev host.Closes #962