test: add publisher field - #137
Closed
vikram-dagger wants to merge 1 commit into
Closed
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| id: Mapped[int] = mapped_column(primary_key=True, index=True) | ||
| title: Mapped[str] = mapped_column(String(255), index=True) | ||
| author: Mapped[str] = mapped_column(String(255)) | ||
| publisher: Mapped[str] = mapped_column(String(255), nullable=False) |
There was a problem hiding this comment.
When any book is created, BookIn and the repository constructor supply only title and author, so the required publisher column receives no value and the request fails with an integrity error returned as HTTP 400.
| id: Mapped[int] = mapped_column(primary_key=True, index=True) | ||
| title: Mapped[str] = mapped_column(String(255), index=True) | ||
| author: Mapped[str] = mapped_column(String(255)) | ||
| publisher: Mapped[str] = mapped_column(String(255), nullable=False) |
There was a problem hiding this comment.
If a deployment already has a books table from an earlier release, create_all does not add the new publisher column, so subsequent ORM reads and writes reference a nonexistent column and fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR adds a required publisher column to the SQLAlchemy Book model.
String(255)database field.Confidence Score: 3/5
This PR is not safe to merge until book creation supplies publisher and existing databases receive a schema migration.
The required column makes current create requests fail on fresh schemas, while deployments with an existing books table will query a column that create_all does not add.
Files Needing Attention: models.py
Important Files Changed
Reviews (1): Last reviewed commit: "test: add publisher field" | Re-trigger Greptile