test: add publisher field - #136
Conversation
Greptile SummaryThis PR adds a required publisher column to the Book ORM model.
Confidence Score: 3/5This PR is not safe to merge until book creation supplies publisher and deployed database schemas are migrated to include the new column. Fresh ORM-created tables reject current inserts because publisher is never supplied, while SQL-initialized and existing databases lack the mapped column entirely. Files Needing Attention: models.py
|
| Filename | Overview |
|---|---|
| models.py | Adds a required ORM field that current create requests cannot populate and deployed database schemas do not contain. |
Reviews (1): Last reviewed commit: "test: add publisher field" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| id: Mapped[int] = mapped_column(primary_key=True, index=True) | ||
| title: Mapped[str] = mapped_column(String(255), index=True) | ||
| author: Mapped[str] = mapped_column(String(255)) | ||
| publisher: Mapped[str] = mapped_column(String(255), nullable=False) |
There was a problem hiding this comment.
When a book is created, BookIn and create_book supply only the title and author, leaving this non-nullable column unset and causing the commit to fail with a constraint violation and the API to return HTTP 400.
| id: Mapped[int] = mapped_column(primary_key=True, index=True) | ||
| title: Mapped[str] = mapped_column(String(255), index=True) | ||
| author: Mapped[str] = mapped_column(String(255)) | ||
| publisher: Mapped[str] = mapped_column(String(255), nullable=False) |
There was a problem hiding this comment.
If the application uses a database initialized from the unchanged db.sql or an existing persistent database, create_all does not add this column, so ORM reads and writes reference a nonexistent publisher column and fail.
1 participant
No description provided.