Skip to content

fix: bump glob to v14 in bundlesize - #742

Merged
aversini merged 1 commit into
mainfrom
claude/glob-v14-upgrade-fe5bde
Nov 5, 2026
Merged

aversini merged 1 commit into
mainfrom
claude/glob-v14-upgrade-fe5bde

Conversation

@aversini

@aversini aversini commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bumps glob from 13.0.6 to 14.0.3 in @node-cli/bundlesize.

  • The package calls glob.sync(fileGlob) in one place, with no options, so the breaking API changes in glob 14 don't affect it: the isMatcher() rename, walk() returning arrays, and the removed debug option.
  • Node engines are unchanged (18 || 20 || >=22).
  • The lockfile shrinks: glob 14.0.3 was already installed through rimraf and @fastify/static, so glob 13, minimatch 10 and path-scurry 2 drop out.

Matching behavior

glob 14 uses minimatch 11, which matches each pattern portion with a non-RegExp matcher (no more ReDoS). The <hash> and <semver> placeholders expand to extglobs, so I ran glob 13.0.6 and 14.0.3 side by side on 15 edge-case filenames with 6 pattern shapes. Both returned identical results.

Test plan

  • tsc --noEmit in bundlesize
  • bundlesize tests: 92/92 pass, using the real glob (not mocked) and covering <hash> and <semver>
  • pnpm install --frozen-lockfile

🤖 Generated with Claude Code

glob 14 moves to minimatch 11, which matches each pattern portion
with a non-RegExp matcher. bundlesize only calls glob.sync() with
no options, so no code changes are needed. The <hash> and <semver>
extglobs were checked against glob 13 on sample filenames and match
the same files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aversini
aversini merged commit f9281c9 into main Nov 5, 2026
4 checks passed
@aversini
aversini deleted the claude/glob-v14-upgrade-fe5bde branch November 5, 2026 14:20
@aversini aversini mentioned this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant