Repository navigation
fix: bump glob to v14 in bundlesize - #742
Merged
Merged
Conversation
glob 14 moves to minimatch 11, which matches each pattern portion with a non-RegExp matcher. bundlesize only calls glob.sync() with no options, so no code changes are needed. The <hash> and <semver> extglobs were checked against glob 13 on sample filenames and match the same files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
globfrom 13.0.6 to 14.0.3 in@node-cli/bundlesize.glob.sync(fileGlob)in one place, with no options, so the breaking API changes in glob 14 don't affect it: theisMatcher()rename,walk()returning arrays, and the removeddebugoption.18 || 20 || >=22).rimrafand@fastify/static, so glob 13, minimatch 10 and path-scurry 2 drop out.Matching behavior
glob 14 uses minimatch 11, which matches each pattern portion with a non-RegExp matcher (no more ReDoS). The
<hash>and<semver>placeholders expand to extglobs, so I ran glob 13.0.6 and 14.0.3 side by side on 15 edge-case filenames with 6 pattern shapes. Both returned identical results.Test plan
tsc --noEmitin bundlesize<hash>and<semver>pnpm install --frozen-lockfile🤖 Generated with Claude Code