Repository navigation
Fix/prompt input hosted file uploads - #523
AbbasFullstack wants to merge 5 commits into
Conversation
|
@AbbasFullstack is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional findings
-
packages/elements/src/prompt-input.tsx:1332-1337— Passing disabled={false} leaves the submit button enabled during uploads because the trailing props spread overrides the upload lock, allowing click handlers to run while form submission silently returns.
| Promise.all( | ||
| capped.map(async (file) => ({ | ||
| filename: file.name, | ||
| mediaType: file.type, | ||
| type: "file" as const, | ||
| url: onFileAdd ? await onFileAdd(file) : URL.createObjectURL(file), | ||
| })) | ||
| ) | ||
| .then((uploaded) => { | ||
| if (usingProvider) { | ||
| controller?.attachments.addUploaded(uploaded); | ||
| } else { | ||
| setItems((prev) => [ | ||
| ...prev, | ||
| ...uploaded.map((file) => ({ ...file, id: nanoid() })), | ||
| ]); | ||
| } | ||
| }) | ||
| .catch(() => { | ||
| // Keep existing attachments if an upload fails. |
There was a problem hiding this comment.
When one file in a multi-file hosted upload rejects, Promise.all discards every successful attachment in that batch without reporting an error or making those remote files available for removal.
| .catch(() => { | ||
| // Keep existing attachments if an upload fails. | ||
| }) | ||
| .finally(() => setIsUploading(false)); |
There was a problem hiding this comment.
When file selections overlap, either batch settling clears isUploading while the other is pending, allowing submission without the pending attachment and letting it appear in the next message.
| const capacity = | ||
| typeof maxFiles === "number" | ||
| ? Math.max(0, maxFiles - files.length) | ||
| : undefined; | ||
| const capped = |
There was a problem hiding this comment.
With maxFiles={1}, selecting a second file while the first upload is pending uploads and appends both files, exceeding the limit in both local and provider modes.
Summary
Adds optional hosted file upload support to "PromptInput".
Changes
Testing
Closes #89