Repository navigation
Conversation
A package function's checker type stays any, so iter.next() was a runtime fence even when the local holds the call-site generator.
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iter.next()was lowered only when the checker's type of the receiver was a generator. Package JavaScript leaves that type asany, so a local that holds a generator became a runtime fence:method calls like 'iter.next' is not supported yet(SC1090).The local or global IR type is used when the checker type is not a generator. The identifier is pure, so the receiver is not evaluated twice.
Differential test:
packages/compiler/test/generator-iterator-next.test.ts. Native stdout, stderr, and exit match Node.Before the change the native binary printed the
SC1090fence above and did not reach[1,2,3].Effect's
Stream.concatreaches this shape throughChannel.fromIterator. The public harness is https://github.com/phall1/effect-scriptc-compat. This patch is the generator receiver check. It does not claim broader Effect parity.