Repository navigation
Conversation
toISOString still throws RangeError. JSON.stringify keeps a json-safe string | null union instead of narrowing the null arm away.
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date.prototype.toJSONhad no lowering (SC2020). Node returnsnullwhen the time value is not finite, and otherwise the same string astoISOString.toISOStringstill throwsRangeError.JSON.stringifywas also narrowing astring | nullunion to the checker'sstringbefore walking it, so the null result threw instead of printingnull. A union that is already JSON-stringify-safe now keeps every arm. A union that is not JSON-safe still narrows.A finite date prints the same ISO string from both methods:
Differential test:
packages/compiler/test/date-tojson.test.ts. Native stdout, stderr, and exit match Node.Before this change both cases failed to compile:
Date.prototype.toJSON is part of the standard library types but has no scriptc lowering yet(SC2020).This showed up while compiling Effect 4. The public harness is https://github.com/phall1/effect-scriptc-compat. The change is the Date method, not an Effect workaround.
Datevalues themselves are still not JSON-safe objects, and a binding the checker types asstringcan still reject the null result, because TypeScript typesDate.toJSON()asstring.