Repository navigation
Update for .NET 11 - #428
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The build script still references removed net8.0 assets, causing signing and copying failures and leaving the new net10.0 and net11.0 assemblies unsigned.
1 open issue
What changed in this PR
Updates AzureSignTool for .NET 11, including framework targets, dependencies, and test infrastructure.
Changes:
- Targets the tool at .NET 10 and 11, and the core library at .NET Standard 2.0 and .NET 10.
- Migrates both test projects to .NET 11 and xUnit’s Microsoft.Testing.Platform integration.
- Updates central package versions and the PR workflow’s SDK.
| File | Description |
|---|---|
test/AzureSignTool.Tests/AzureSignTool.Tests.csproj |
Moves tool tests to .NET 11 and the new test runner. |
test/AzureSign.Core.Tests/AzureSign.Core.Tests.csproj |
Moves core tests to .NET 11 and the new test runner. |
src/AzureSignTool/AzureSignTool.csproj |
Updates tool targets and removes the cryptography compatibility dependency. |
src/AzureSign.Core/AzureSign.Core.csproj |
Replaces the .NET 8 target with .NET 10 and updates the AOT condition. |
global.json |
Selects Microsoft.Testing.Platform for test execution. |
Directory.Packages.props |
Updates dependencies and replaces legacy test packages. |
.github/workflows/pr.yml |
Selects the .NET 11 SDK for PR tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.