Repository navigation
fix(api): make POST /library/scan admin only - #4095
Merged
Merged
Conversation
The scan walks the global library with no owner filter, so under multi user enforcement any signed in user could trigger it. Put it in the same admin group as GET /library/scan/status. The scheduler calls the scanner directly, and the only web callers (Settings scan panel, adoption view) are admin only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: vavallee <vavallee@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /library/scan was registered without RequireAdmin while GET /library/scan/status is admin gated. The scan walks the global library with no owner filter, so under multi user enforcement any signed in user could start a full walk and its reconciliation side effects.
Now in the same admin group as the status route. Callers checked: Settings scan button (inside the isAdmin block), adoption view (ImportPage renders it for admins only; its other routes are admin only), scheduler (calls the scanner directly, not HTTP). Disabled, local-only and API key modes carry the admin role, so they are unchanged. OPDS does not use the route. Docs updated.
Test: non admin and no role get 403 without starting a scan, admin gets 202. Fails with the route ungated (202 and a scan started for user and no role).
🤖 Generated with Claude Code