Repository navigation
ci(ai-sweep): limit the scheduled sweep to adding the needs-triage label - #4085
Merged
Merged
Conversation
Hardening: the sweep reads untrusted issue text and held a blanket gh issue edit permission. Allow only the needs-triage label add its prompt uses and deny the other edit flags. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: vavallee <vavallee@protonmail.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: vavallee <vavallee@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening for the nightly sweep. It reads untrusted issue text and held
Bash(gh issue edit:*), which covers every edit flag. Its prompt (step 3) only ever addsneeds-triageto unlabelled issues.Bash(gh issue edit * --add-label needs-triage). Claude Code permission rules accept*anywhere in the rule, and a compound command is split so each part must match.--disallowedToolsentries for the othergh issue editflags (body, title, remove-label, assignees, milestone, project).*also stands for any options before--add-label, so an allow rule alone cannot forbid--body x --add-label needs-triage. The deny list covers that, but it is a list of flags, not a closed set. The egress allowlist and no push token remain the backstops. Pins are unchanged.Test plan
🤖 Generated with Claude Code