Repository navigation
Conversation
…onschema-go - Deduplicate schema validation: align with modelcontextprotocol/go-sdk and nexusdock, both of which natively use google/jsonschema-go. - Drop santhosh-tekuri/jsonschema/v6 and 12 transitive golang.org/x/text packages from the dependency tree (-640 KiB binary size). - Simplify internal/tool/contract by removing obsolete error-tree helpers in favor of direct error reporting.
Owner
|
Thanks for the contribution. This change has been superseded by #248, which keeps the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for building such a great tool and ecosystem!
Noticed that
modelcontextprotocol/go-sdkalready pulls ingoogle/jsonschema-go, andnexusdockuses it as well. Maintainingsanthosh-tekuri/jsonschema/v6alongside it is redundant and keepsgolang.org/x/textin the dependency tree.This PR replaces
santhosh-tekuriwithgoogle/jsonschema-go:santhosh-tekuri/jsonschema/v6andgolang.org/x/textfromgo.mod(shaves ~640 KiB off the binary).internal/tool/contract/validator.goby removing the custom error-tree walker in favor of direct error reporting.Tested with
go test ./..., all tool input and output schema validations pass.