Repository navigation
sysctl: treat -o and -x as flags that take no value - #837
Merged
Merged
Conversation
procps-ng documents -o and -x as no-ops for BSD compatibility. They must not consume the next operand, so sysctl -o kernel.ostype prints the key instead of treating the key as an argument to -o.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 19.20% 20.11% +0.91%
==========================================
Files 68 68
Lines 10156 10343 +187
Branches 546 552 +6
==========================================
+ Hits 1950 2081 +131
- Misses 8206 8262 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #835.
procps-ng documents
-oand-xas no-ops for BSD compatibility. They do not take a value, sosysctl -o kernel.ostypeshould print the key. On main, clap treated both as options with a value, which swallowed the operand and printed help instead.sysctl -o -n kernel.ostypefailed witha value is required for '-o <noop_o>'.I set
ArgAction::SetTrueon both flags, which also drops the<noop_o>/<noop_x>placeholders from--help.sysctl -ox kernel.ostypealready worked and is covered by the new test.I found the mismatch with behave, against GNU procps-ng 4.0.4.
cargo test -j 1 --no-default-features --features sysctl,pmap --test tests,cargo fmt --check, andcargo clippy -j 1 --no-default-features --features sysctl,pmap --all-targets -- -D warningspass. I skipped the default feature set becauseuu_topneeds libsystemd, which is not installed on this machine.