Repository navigation
Conversation
GET /api/models returns the backend list shape { data: { items } }
(wrapListResponse), but modelService.getAll() only handled a raw array or
{ data: [] } and returned the { items } object. models.length was then
undefined, so DeviceDetail never rendered the Display Format <select>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 0.6.0 the Display Format selector on the device detail page is never rendered, so it's impossible to switch a device to the BMP or TRMNL X models from the UI.
GET /api/modelsreturns the backend list shape{ data: { items: [...] } }(wrapListResponseinModelsService.findAll), butmodelService.getAll()only handled a raw array or{ data: [...] }, so it returned the{ items }object.models.lengthwas thenundefined, so the{models && models.length > 0 && …}block inDeviceDetail.tsxwas skipped.Fix: also unwrap
data.items. A regression test fails before and passes after.bun run testgives 21 passed andbun run buildis OK.