Skip to content

ci(web): run the production build, use the .nvmrc Node, and test shared-package changes - #511

Merged
KMKoushik merged 1 commit into
mainfrom
hq/ci-production-build
Nov 15, 2026
Merged

KMKoushik merged 1 commit into
mainfrom
hq/ci-production-build

Conversation

@KMKoushik

@KMKoushik KMKoushik commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Closes the gaps that let #499's build error reach main (fixed in #510):

  • Production build step (pnpm build:editor && pnpm build:web). Next.js validates route handler signatures and page exports only during next build, so the typecheck and tests passed while Railway's build failed.
  • Node from .nvmrc (24.22.3) instead of 22, the same as Railway's Railpack build.
  • Wider path filters: packages/**, the lockfile, root package/workspace/turbo config, .nvmrc and this workflow now trigger the job. Before, only apps/web/** did, so e.g. fix(smtp): install the SMTP server from the monorepo lockfile in every build #505's lockfile change never ran web tests.

Ask Polylane for an impact assessment of this pull request:

Assess with Polylane


Summary by cubic

Updates the web CI workflow so it catches the same build failures that break production.

  • Runs a production build (pnpm build:editor && pnpm build:web) after typechecking, since Next.js only validates route handlers and page exports during next build.
  • Uses the Node version from .nvmrc (24.22.3) instead of 22, matching Railway.
  • Triggers the job on changes to packages/**, the lockfile, root config files, .nvmrc, and this workflow, not just apps/web/**.

Written for commit 1a39e6d. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Tests
    • Pull request and main branch checks now run for changes to the web app, shared packages, root manifests and configuration, .nvmrc, and the workflow.
    • Test runs use the Node version specified by the project.
    • Production builds of the editor and web apps now run after type checking, with cloud mode enabled and environment validation skipped.

@vercel

vercel Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
unsend-marketing Ready Ready Preview Nov 15, 2026 10:58pm UTC

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The web test workflow now runs for changes to shared packages, root manifests and configuration, .nvmrc, and the workflow itself, as well as changes under apps/web/**. It reads the Node version from .nvmrc. After type checking, it runs production builds for the editor and web apps with environment validation skipped and NEXT_PUBLIC_IS_CLOUD set to "true".

Change: Other

Merge Risk: Low · up to 1a39e

This PR strengthens web CI with a production build and broader path filters. Two small gaps remain: changes to other workspace app manifests don't trigger the workflow, and the build step runs with NODE_ENV=test instead of production. Neither affects production behavior, and both are quick to fix.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying usesend with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a39e6d
Status: ✅  Deploy successful!
Preview URL: https://88c7c344.usesend.pages.dev
Branch Preview URL: https://hq-ci-production-build.usesend.pages.dev

View logs

@KMKoushik
KMKoushik merged commit 78f9b39 into main Nov 15, 2026
6 checks passed
@KMKoushik
KMKoushik deleted the hq/ci-production-build branch November 15, 2026 23:01

This branch was successfully deployed

1 active deployment
Preview — 1a39e6db Deployed Nov 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant