Repository navigation
ci(web): run the production build, use the .nvmrc Node, and test shared-package changes - #511
Conversation
…ges to shared packages and the lockfile
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughThe web test workflow now runs for changes to shared packages, root manifests and configuration, Change: Other Merge Risk:
|
Deploying usesend with
|
| Latest commit: |
1a39e6d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88c7c344.usesend.pages.dev |
| Branch Preview URL: | https://hq-ci-production-build.usesend.pages.dev |
Closes the gaps that let #499's build error reach main (fixed in #510):
pnpm build:editor && pnpm build:web). Next.js validates route handler signatures and page exports only duringnext build, so the typecheck and tests passed while Railway's build failed..nvmrc(24.22.3) instead of 22, the same as Railway's Railpack build.packages/**, the lockfile, root package/workspace/turbo config,.nvmrcand this workflow now trigger the job. Before, onlyapps/web/**did, so e.g. fix(smtp): install the SMTP server from the monorepo lockfile in every build #505's lockfile change never ran web tests.Ask Polylane for an impact assessment of this pull request:
Summary by cubic
Updates the web CI workflow so it catches the same build failures that break production.
pnpm build:editor && pnpm build:web) after typechecking, since Next.js only validates route handlers and page exports duringnext build..nvmrc(24.22.3) instead of 22, matching Railway.packages/**, the lockfile, root config files,.nvmrc, and this workflow, not justapps/web/**.Written for commit 1a39e6d. Summary will update on new commits.
Summary by CodeRabbit
mainbranch checks now run for changes to the web app, shared packages, root manifests and configuration,.nvmrc, and the workflow.