helpers: materialize a non-lvalue instance before calling a helper (fixes upstream#41589) - #47
Open
Moonbot-Tech wants to merge 1 commit into
Open
helpers: materialize a non-lvalue instance before calling a helper (fixes upstream#41589)#47Moonbot-Tech wants to merge 1 commit into
Moonbot-Tech wants to merge 1 commit into
Conversation
…ixes upstream#41589) A record-valued property read is flagged nf_no_lvalue, but helper lookup passed the backing field directly as hidden Self, so a mutating helper method changed the field behind a property read while the same call on a getter worked on a copy. Move the existing materialization of constant and address nodes into materialize_helper_instance, call it from the common consumer do_member_read, and let it accept nf_no_lvalue nodes as well: a genuine lvalue keeps its address, a non-lvalue is copied into a temporary with normal cleanup. FPC issue: https://gitlab.com/freepascal.org/fpc/source/-/issues/41589 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fibodevy
added
the
waiting-upstream
Author
|
FPC merge request: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/1551 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. FPC issue #41589: a record-valued property read is flagged
nf_no_lvalue, but helper lookup passed the backing field directly as hiddenSelf, so a mutating helper method changed the field behind a property read while the same call on a getter worked on a copy.Fix. In
pexpr.pasmove the existing materialization of constant and address nodes intomaterialize_helper_instance, call it from the common consumerdo_member_read, and let it acceptnf_no_lvaluenodes as well: a genuine lvalue keeps its address, a non-lvalue is copied into a temporary with normal cleanup.Test.
tests/webtbs/tw41589.pp: the backing field is mutated through the property read on currentmain(exit code 3), unchanged after the fix.Validation. Win64 build of
main(a359fc1) with the patch; 405 neighbouring tests fromtests/test(inline, rtti, helpers, generics, opt) give identical results before and after.🤖 Generated with Claude Code