Maker Battle Repartition (Admin & User faces) - #161
Merged
tuturd merged 18 commits intoAug 30, 2026
Conversation
11 tasks
tuturd
changed the title
…arche plus on verra demain)
…ction 163 feature uploads exports protection
Remi-pcn
marked this pull request as ready for review
August 30, 2026 11:50
tuturd
changed the title
tuturd
commented
Aug 30, 2026
| res.setHeader('Content-Type', 'application/json'); | ||
| res.setHeader('Content-Disposition', `attachment; filename="bus_${Date.now()}.json"`); | ||
|
|
||
| return res.status(200).json(exportData); |
Member
Author
There was a problem hiding this comment.
faudrait passer par un Ok
| res.setHeader('Content-Type', 'application/json'); | ||
| res.setHeader('Content-Disposition', `attachment; filename="team_members_${Date.now()}.json"`); | ||
|
|
||
| return res.status(200).json(exportData); |
Member
Author
There was a problem hiding this comment.
faudrait passer par un Ok
Comment on lines
+9
to
+24
| export interface UserWithTeamFaction { | ||
| user_id: number; | ||
| group: string; | ||
| team_id: number; | ||
| faction_id: number; | ||
| } | ||
|
|
||
| export interface TeamsWithGroup { | ||
| maker_team_id: number; | ||
| group: string; | ||
| } | ||
|
|
||
| export interface MakerBattleExport { | ||
| maker_team_id: number; | ||
| table: number; | ||
| } |
Member
Author
There was a problem hiding this comment.
faudrait passer les types dans un fichier externe
Comment on lines
+6
to
+25
| export interface teamMemberUser { | ||
| prenom: string; | ||
| nom: string; | ||
| ce: boolean; | ||
| equipe: string | null; | ||
| } | ||
|
|
||
| export interface busUser { | ||
| id: number; | ||
| prenom: string; | ||
| nom: string; | ||
| mail: string; | ||
| telephone: string; | ||
| nouveau: boolean; | ||
| ce: boolean; | ||
| num_equipe: number | null; | ||
| benevole: boolean; | ||
| orga: boolean; | ||
| majeur: boolean; | ||
| } |
Member
Author
There was a problem hiding this comment.
faudrait passer les types dans un fichier externe
Member
Author
|
Les commentaires restants seront corrigés dans une future mise en production étant donné le délai imposé. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.