-
Notifications
You must be signed in to change notification settings - Fork 8
Swarm proxy as a polynomial per cell, PIC transport, and one characteristic trace per solver #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4fa6350
IntegrationPointVariable: any number of components
lmoresi c953786
SwarmVariable proxy_location='integration_points': particles to the i…
lmoresi 400b2de
Docs: swarm proxy at the integration points
lmoresi dade727
Test: layered Couette flow, interface on mesh edges, exact with the i…
lmoresi ebe100e
SwarmVariable proxy_location='cells': least-squares polynomial per cell
lmoresi c7a5cee
Evaluator: forward `simplify` to the local path; cells proxy: bounded…
lmoresi 6c24a81
Test: FLIP invalid-option probe passes the required continuous argument
lmoresi ea6d1bd
Lagrangian_Swarm samples its history before the particles first move
lmoresi 2980af7
DDt histories share one characteristic trace per solver
lmoresi 3cfe2ed
Evaluator: internal simplify defaults off, matching the public API
lmoresi 3162bef
Merge remote-tracking branch 'origin/development' into feature/integr…
lmoresi 2980bcb
Review (#707): refresh the proxy before the FLIP read-back, drop a mi…
lmoresi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the follow-up commit: the proxy is refreshed first on every path of _proxy_values_at_particles, the misplaced copy of the helper in the nodal-swarm Lagrangian class is removed, bcs defaults to None, and the create_delta_fe docstring now describes the multi-component element.