refactor(speculation): move the scorer in with the rest of speculation - #625
Open
behinddwalls wants to merge 1 commit into
Open
refactor(speculation): move the scorer in with the rest of speculation#625behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary ### Why? The Speculator is composed from a generator, an allocator and a scorer, but only two of the three lived under `submitqueue/extension/speculation/`. The scorer sat at the top level as if it were a peer of storage or the change provider, which it is not: there is no scoring stage, and nothing outside the speculation generator has ever asked it for a price. The tree implied a seam that does not exist. ### What? `submitqueue/extension/scorer/` becomes `submitqueue/extension/speculation/scorer/`, taking its contract, `heuristic`, `composite`, `fake` and `mock` with it. Import paths and BUILD files follow; no code changes. The `mocks` Makefile target listed the old path explicitly. It is dropped rather than repointed, because the `./submitqueue/extension/speculation/...` pattern already on that line now covers it. ## Test Plan ✅ `bazel test //submitqueue/... //service/...` — 53 tests pass ✅ `make gazelle` — BUILD files regenerated ✅ `make mocks` — unchanged output from the new path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The Speculator is composed from a generator, an allocator and a scorer, but only two of the three lived under
submitqueue/extension/speculation/. The scorer sat at the top level as if it were a peer of storage or the change provider, which it is not: there is no scoring stage, and nothing outside the speculation generator has ever asked it for a price. The tree implied a seam that does not exist.What?
submitqueue/extension/scorer/becomessubmitqueue/extension/speculation/scorer/, taking its contract,heuristic,composite,fakeandmockwith it. Import paths and BUILD files follow; no code changes.The
mocksMakefile target listed the old path explicitly. It is dropped rather than repointed, because the./submitqueue/extension/speculation/...pattern already on that line now covers it.Test Plan
✅
bazel test //submitqueue/... //service/...— 53 tests pass✅
make gazelle— BUILD files regenerated✅
make mocks— unchanged output from the new pathStack