Skip to content

feat(demo): add BURST mode for a simultaneous enqueue of independent changes - #615

Merged
behinddwalls merged 1 commit into
mainfrom
preetam/demo-burst-mode
Aug 20, 2026
Merged

feat(demo): add BURST mode for a simultaneous enqueue of independent changes#615
behinddwalls merged 1 commit into
mainfrom
preetam/demo-burst-mode

Conversation

@behinddwalls

@behinddwalls behinddwalls commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add -burst (Makefile BURST=false) which, for independent changes, creates every change first and only then fires all the Land calls together, so the requests reach the queue in one burst instead of being enqueued as each is created. It works for every provider: burst runs each source through the same two phases, so fake creates instantly, github creates concurrently, git creates serially on its single work tree — and in all three the enqueues arrive together once creation is done.

Burst does not make creation faster; with the git source it is still serialized on one work tree. It only separates creation from enqueuing so the publishes are not spread across the creation phase. The default is unchanged — each change lands the moment it exists, so the queue starts working during creation.

A small lander seam lets the two-phase ordering be tested without a live gateway.

Test Plan

✅ New unit test asserts nothing is enqueued until every change is created, provider-agnostically (a lander seam + a recording source stand in for any provider); shape banner covered; existing //service/submitqueue/demo/requests tests green.

Stack

  1. @ feat(demo): add BURST mode for a simultaneous enqueue of independent changes #615
  2. fix(orchestrator): carry a failed batch's reason to the request error log #616

…changes

Add -burst (Makefile BURST=false) which, for independent changes, creates every change first and only then fires all the Land calls together, so the requests reach the queue in one burst instead of being enqueued as each is created. It works for every provider: burst runs each source through the same two phases, so fake creates instantly, github creates concurrently, git creates serially on its single work tree — and in all three the enqueues arrive together once creation is done.

Burst does not make creation faster; with the git source it is still serialized on one work tree. It only separates creation from enqueuing so the publishes are not spread across the creation phase. The default is unchanged — each change lands the moment it exists, so the queue starts working during creation.

A small lander seam lets the two-phase ordering be tested without a live gateway.

# Conflicts:
#	service/submitqueue/demo/requests/BUILD.bazel

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# interactive rebase in progress; onto 97dc5da
# Last command done (1 command done):
#    pick babf53a # feat(demo): add BURST mode for a simultaneous enqueue of independent changes
# No commands remaining.
# You are currently rebasing branch 'preetam/demo-burst-mode' on '97dc5da9'.
#
# Changes to be committed:
#	modified:   Makefile
#	modified:   service/submitqueue/demo/requests/BUILD.bazel
#	modified:   service/submitqueue/demo/requests/main.go
#	modified:   service/submitqueue/demo/requests/main_test.go
#
@behinddwalls
behinddwalls force-pushed the preetam/demo-burst-mode branch from babf53a to 115b3d3 Compare August 20, 2026 01:01
@behinddwalls
behinddwalls added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 9f8a3ef Aug 20, 2026
15 checks passed
@behinddwalls
behinddwalls deployed to stack-rebase August 20, 2026 03:47 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the preetam/demo-burst-mode branch August 20, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants