Repository navigation
ritmo-tools pixel review: keep what the person says, and tell the agent the truth about it - #188
Merged
Merged
Conversation
…nt the truth about it What #187 left, each found by running the tool on the real games' art: - Saving stopped for good once the agent renamed art the page held a review of, or `pixel fix` put X.fixed.png in place of X.png. The server now writes what it finds and says back the rest, whose review stays under its old name. The review's version also follows which assets are found, so a page that has not heard an asset came back cannot write over that asset's review. - A comment being typed was lost on a click on a status, on the agent's reply, or on moving on. Its text now lives in the page's state, and moving to another asset, animation, or view adds it. Cancel or Esc drops it. - `pixel notes` said "Leave it as it is" about an approved asset with open comments, and counted a commented asset with no status as not reviewed. - A folder of thousands blocked the server for minutes: nothing answered, not even the page. Reads now take turns, so it answers between them, and the page says how far it is. Past 500 assets, review and notes warn. A picture is served as its file instead of a copy written up front, which saves a third of the time and most of the memory. - Holding an arrow key in Safari hit its limit of 100 address changes in 10 seconds, and the page stopped moving. The address now follows once it settles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g it takes to check A look at the list answered with the list only if it beat the wait, even with every read done. Checking the files of a large folder on a slow disk could lose that race on every look, leaving the page on "2128 of 2128" for good. CI hit it through the new test, which never waits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the breaking problems #187 listed as known. Each was reproduced on copies of the real games' art first, then checked again after the fix.
What changes
pixel fixputX.fixed.pngin place ofX.png, every later save failed withno such assetuntil a reload, which lost what was unsaved. Now the server writes the assets it finds and says back the rest. A review of a name no longer found stays inpixel.review.jsonunder that name, andpixel noteslists it undergone.pixel notesno longer misleads. An approved asset with open comments no longer says "Leave it as it is". An asset with a note or comments but no status comes ahead of untouched ones, and the summary counts it apart.pixel reviewprints awarningandpixel noteswarns on stderr before it starts reading.Decisions to check
spirit-call/artis 2128, mostly 3D renders. It warns and carries on: a large folder may be what the agent meant.Measured on
spirit-call/art(2128 PNGs)pixel notesBefore and after were single runs, so take the times as rough. The "after" runs had other tests going beside them.
Verification
pnpm run check(1401 tests) andpnpm pack:checkpass.website/isn't touched.test/pixel-review.test.tscover saving after a rename, a stale page and an asset coming back, the list answering while it reads,nextwith open comments, and the order and summary.pixel fix; 150 presses of ↓; the notes.Not covered
sourcein the notes. It still only shows when the source sits beside the PNG, so Still Time's notes don't name theirs. Nothing breaks without it, and fixing it needs a decision on how a game declares where its sources are.🤖 Generated with Claude Code