Repository navigation
Fix empty chart 500 in native image; smoke-test the image in CI - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the native-image empty-chart fix and added CI smoke coverage.
No open issues 🎉
What changed in this PR
Fixes the native-image failure when rendering a chart without data and adds CI smoke coverage for the built image.
Changes:
- Registers
kotlin.collections.EmptyListfor reflection to address the empty-chart HTTP 500. - Starts the native-image container in CI and checks
/,/tables,/forms, and/lineChartComponent?name=Sales.
| File | Description |
|---|---|
src/main/kotlin/de/tschuehly/fullstackdemo/common/NativeHints.kt |
Adds reflection hints for Kotlin’s empty-list implementation. |
.github/workflows/native-image.yml |
Adds container startup, readiness polling, and endpoint smoke checks with failure logs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native image returned 500 for
/lineChartComponent?name=Sales(no data): Kotlin reflection could not resolvekotlin.collections.EmptyList. The live Boot 3.2 site returns an empty chart.NativeHintsregisterskotlin.collections.EmptyListfor reflection./,/tables,/formsand the empty chart.Commit 1 adds only the smoke test, so its run shows the 500; commit 2 adds the hint.