Skip to content

fix: require Node 20 in docs, test on Node 20 and 22, update npm keywords (1.7.2) - #80

Merged
Starllordz merged 1 commit into
mainfrom
fix/node-min-ci-keywords
Oct 29, 2026
Merged

Starllordz merged 1 commit into
mainfrom
fix/node-min-ci-keywords

Conversation

@Starllordz

@Starllordz Starllordz commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • README — both Requirements sections said Node.js v18 or higher, but engines.node is >=20. Both now say Node.js 20 or higher. The pnpm line is unchanged.
  • CI — publish.yml was the only workflow and ran on Node 22.23.4 only, so the declared minimum was never tested. New .github/workflows/test.yml runs pnpm install --frozen-lockfile, pnpm run build and pnpm run test on every pull request and on pushes to main, with a node-version: ['20', '22'] matrix. If the Node 20 job fails, engines must be raised before merging.
  • npm keywords — replaced with laratranslate, lara, translation, translate, localization, i18n, l10n, internationalization, cli, command-line, ai, translated. The registry only picks these up with a new version.
  • Version bumped to 1.7.2 in package.json and the README badge.

Test plan

  • pnpm test: 978/978 pass (Node 22, locally)
  • pnpm run build: no errors
  • pnpm run lint: clean
  • prettier is clean on the changed files; pnpm run format:check still flags glossary.ts, memory.ts and error.ts, which were already on main and are not touched here
  • Test workflow green on Node 20 and 22 (this PR)
  • After publish: npm i -g @translated/lara-cli, init --non-interactive, translate on Node 20 with real credentials

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

…ords (1.7.2)

- README: Node.js v18 -> 20 in both Requirements sections, to match engines.node >=20
- CI: new test.yml runs build and tests on pull requests and pushes to main, Node 20 and 22
- package.json: keywords aligned with the other Lara packages
- Version bumped to 1.7.2
@Starllordz
Starllordz merged commit 9698451 into main Oct 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants