Repository navigation
fix: require Node 20 in docs, test on Node 20 and 22, update npm keywords (1.7.2) - #80
Merged
Merged
Conversation
…ords (1.7.2) - README: Node.js v18 -> 20 in both Requirements sections, to match engines.node >=20 - CI: new test.yml runs build and tests on pull requests and pushes to main, Node 20 and 22 - package.json: keywords aligned with the other Lara packages - Version bumped to 1.7.2
Khalester
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node.js v18 or higher, butengines.nodeis>=20. Both now sayNode.js 20 or higher. The pnpm line is unchanged.publish.ymlwas the only workflow and ran on Node22.23.4only, so the declared minimum was never tested. New.github/workflows/test.ymlrunspnpm install --frozen-lockfile,pnpm run buildandpnpm run teston every pull request and on pushes tomain, with anode-version: ['20', '22']matrix. If the Node 20 job fails,enginesmust be raised before merging.laratranslate, lara, translation, translate, localization, i18n, l10n, internationalization, cli, command-line, ai, translated. The registry only picks these up with a new version.package.jsonand the README badge.Test plan
pnpm test: 978/978 pass (Node 22, locally)pnpm run build: no errorspnpm run lint: cleanpnpm run format:checkstill flagsglossary.ts,memory.tsanderror.ts, which were already onmainand are not touched hereTestworkflow green on Node 20 and 22 (this PR)npm i -g @translated/lara-cli,init --non-interactive,translateon Node 20 with real credentialsNeed help on this PR? Tag
@codesmith-botwith what you need.