Skip to content

Add dark semantic color tokens - #722

Merged
bencmbrook merged 2 commits into
mainfrom
fdufbos/gan-932-dark-tokens
Nov 14, 2026
Merged

bencmbrook merged 2 commits into
mainfrom
fdufbos/gan-932-dark-tokens

Conversation

@FDufBos

@FDufBos FDufBos commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Related Issues

Internal Changelog

  • Populate color-dark.tokens.json with the admin-dashboard dark overrides, so color.dark exports real dark values (minor bump for @transcend-io/design-tokens)
  • Emit dark semantic colors in tokens.css under an opt-in [data-theme="dark"] selector. Only semantic color groups are included (palette and typography are mode-invariant and stay on :root), and rest-state aliases are redeclared so nested dark scopes resolve correctly. Opt-in rather than prefers-color-scheme so MCP App views, which deliberately keep cards on light tokens, are unaffected.

Testing

  • tz check, build, vitest, and typecheck pass for design-tokens; pre-commit and pre-push hooks pass
  • Generated color.dark deep-equals main's current merge(color.light, DARK_SEMANTIC_COLOR_OVERRIDES), including rest-state toString
  • New test asserts the [data-theme="dark"] block sets color-scheme: dark, carries dark values and aliases, and doesn't repeat palette or typography declarations

Follow-up (main)

After release: bump @transcend-io/design-tokens in main's catalog, delete darkSemanticColorOverrides.ts, drop the semantic dark merge in createAdminDashboardTheme, and resolve the GAN-932 TODOs.

Made with Cursor

Moves the admin-dashboard dark overrides into color-dark.tokens.json
so color.dark ships real values for every consumer.

- ref https://linear.app/transcend/issue/GAN-932

Co-authored-by: Cursor <cursoragent@cursor.com>
@linear-code

linear-code Bot commented Nov 14, 2026

Copy link
Copy Markdown

GAN-932

@pkg-pr-new

pkg-pr-new Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@transcend-io/airgap.js-types

pnpm add https://pkg.pr.new/@transcend-io/airgap.js-types@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/airgap.js-types@ee52b2c.tgz

@transcend-io/cli

pnpm add https://pkg.pr.new/@transcend-io/cli@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/cli@ee52b2c.tgz

@transcend-io/custom-function-types

pnpm add https://pkg.pr.new/@transcend-io/custom-function-types@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/custom-function-types@ee52b2c.tgz

@transcend-io/design-tokens

pnpm add https://pkg.pr.new/@transcend-io/design-tokens@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/design-tokens@ee52b2c.tgz

@transcend-io/internationalization

pnpm add https://pkg.pr.new/@transcend-io/internationalization@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/internationalization@ee52b2c.tgz

@transcend-io/privacy-types

pnpm add https://pkg.pr.new/@transcend-io/privacy-types@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/privacy-types@ee52b2c.tgz

@transcend-io/sdk

pnpm add https://pkg.pr.new/@transcend-io/sdk@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/sdk@ee52b2c.tgz

@transcend-io/secret-value

pnpm add https://pkg.pr.new/@transcend-io/secret-value@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/secret-value@ee52b2c.tgz

@transcend-io/type-utils

pnpm add https://pkg.pr.new/@transcend-io/type-utils@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/type-utils@ee52b2c.tgz

@transcend-io/utils

pnpm add https://pkg.pr.new/@transcend-io/utils@ee52b2c
yarn add https://pkg.pr.new/@transcend-io/utils@ee52b2c.tgz

commit: ee52b2c

Scoped to [data-theme="dark"] so CSS consumers can opt in; MCP App
views stay light unless they set the attribute.
@FDufBos
FDufBos marked this pull request as ready for review November 14, 2026 02:08
@FDufBos
FDufBos requested a review from a team as a code owner November 14, 2026 02:08
@FDufBos
FDufBos requested a review from bencmbrook November 14, 2026 02:08

@bencmbrook bencmbrook left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha awesome, thank you!

@bencmbrook
bencmbrook added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit dc352f1 Nov 14, 2026
6 checks passed
@bencmbrook
bencmbrook deleted the fdufbos/gan-932-dark-tokens branch November 14, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants