Repository navigation
Add dark semantic color tokens - #722
Merged
Merged
Conversation
Moves the admin-dashboard dark overrides into color-dark.tokens.json so color.dark ships real values for every consumer. - ref https://linear.app/transcend/issue/GAN-932 Co-authored-by: Cursor <cursoragent@cursor.com>
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/custom-function-types
@transcend-io/design-tokens
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/secret-value
@transcend-io/type-utils
@transcend-io/utils
commit: |
Scoped to [data-theme="dark"] so CSS consumers can opt in; MCP App views stay light unless they set the attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Internal Changelog
color-dark.tokens.jsonwith the admin-dashboard dark overrides, socolor.darkexports real dark values (minor bump for@transcend-io/design-tokens)tokens.cssunder an opt-in[data-theme="dark"]selector. Only semantic color groups are included (palette and typography are mode-invariant and stay on:root), and rest-state aliases are redeclared so nested dark scopes resolve correctly. Opt-in rather thanprefers-color-schemeso MCP App views, which deliberately keep cards on light tokens, are unaffected.Testing
tz check, build, vitest, and typecheck pass fordesign-tokens; pre-commit and pre-push hooks passcolor.darkdeep-equals main's currentmerge(color.light, DARK_SEMANTIC_COLOR_OVERRIDES), including rest-statetoString[data-theme="dark"]block setscolor-scheme: dark, carries dark values and aliases, and doesn't repeat palette or typography declarationsFollow-up (main)
After release: bump
@transcend-io/design-tokensin main's catalog, deletedarkSemanticColorOverrides.ts, drop the semantic dark merge increateAdminDashboardTheme, and resolve the GAN-932 TODOs.Made with Cursor