Repository navigation
docs(cli): name the Custom Function type each custom-functions new template creates - #539
Conversation
|
@cursoragent fix ci and fix the pr descriptoin |
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/custom-function-types
@transcend-io/design-tokens
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/type-utils
@transcend-io/utils
@transcend-io/mcp
@transcend-io/mcp-server-admin
@transcend-io/mcp-server-assessment
@transcend-io/mcp-server-base
@transcend-io/mcp-server-consent
@transcend-io/mcp-server-discovery
@transcend-io/mcp-server-docs
@transcend-io/mcp-server-dsr
@transcend-io/mcp-server-inventory
@transcend-io/mcp-server-preferences
@transcend-io/mcp-server-workflows
commit: |
|
CI is fully green on PR #539 after one commit ( CI fixes — two real failures, both caused by the copy change to
I verified locally before pushing: genfiles is clean, the changeset check passes, and all 187 CLI Custom Function tests pass including the Deno contract checks on every template (I had to install Deno 2.4.5 and shellcheck 0.11.0 in this VM, which the CI images provide). PR description — I retitled the PR from the branch-name placeholder to |
custom-functions new template creates


Copy-only change to
transcend custom-functions new, so the template choice describes the two Custom Function types a caller is actually picking between instead of the code the scaffolder emits.Why
The command described its templates in terms of generated code — "General or DSR starter", "Generated handler and fixture shape", "Starter type:" — which does not map onto the product concepts. A caller choosing a template is choosing between a General Custom Function, triggered by Rules Automation, and a DSR Custom Function, which can support a data point resolver, a preflight check, or both.
dsr-enricherin particular reads as the API's internal export name rather than the user-facing preflight workflow.What changed
new/impl.ts) — options now lead with the type: "General Custom Function — triggered by Rules Automation", "DSR Custom Function", "DSR Custom Function — data point resolver only", "DSR Custom Function — preflight check only". The combined DSR option is listed first among the DSR entries as the common default.new/command.ts) —--templateis "Function type and generated handler shape", and the full description spells out both types.new/readme.ts) — explains which flag value to pick per type, and notes thatdsr-enricherkeeps the API's technical export name while the user-facing workflow is called preflight.lib/custom-functions/scaffold-templates.ts) — the generated DSR enricher handler and its test payload use preflight wording.skills/transcend-custom-functions/references/setup.md) — pins "Install Deno 2.4.5" to match the version this repository validates against, instead of "Install Deno 2".packages/cli/README.md) — regenerated from the above viapnpm --dir packages/cli genfiles.No behavior, flag values, or generated code structure changed:
general,dsr-datapoint,dsr-enricher, anddsr-bothall still produce exactly what they did before.Testing
pnpm --dir packages/cli genfilesis clean.vitest run src/lib/custom-functions src/commands/custom-functions, 187 tests).