Repository navigation
Conversation
Make the `whoami` dependency a feature gate (`whoami`) on `sqlx-postgres` so it can be disabled by users who don't need OS username fallback. When disabled, the default username falls back to "unknown" if `PGUSER` is not set. The feature is included in the top-level `sqlx` crate's default features, so existing behavior is preserved. Follows up on transact-rs#1571 and transact-rs#2319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases the work of #4170, thanks to richochet for the implementation. I think it was just closed due to lack of response from maintainers, but I'm happy to wait.
Make the
whoamidependency a feature gate (whoami) onsqlx-postgresso it can be disabled by users who don't need OS username fallback.When disabled, the default username falls back to "unknown" if
PGUSERis not set.Does your PR solve an issue?
fixes #4443
Is this a breaking change?
yes, adding a new feature to maintain existing behaviour is technically a breaking change for users who have
default-features = false.I've noticed that some maintainers are happy to consider such changes as non-breaking, your choice.
Alternatives
If we want to avoid introducing a new feature for this, having unix systems just read the $USER env var would be fine for me, windows can continue to use the whoami crate.